On Thu, Feb 10, 2022, Paolo Bonzini wrote: > On 2/10/22 17:55, Sean Christopherson wrote: > > > union kvm_mmu_page_role root_role; > > > union kvm_mmu_paging_mode cpu_mode; > > > > I'd prefer to not use "paging mode", the SDM uses that terminology to refer to > > the four paging modes. My expectation given the name is that the union would > > track only CR0.PG, EFER.LME, CR4.PAE, and CR4.PSE[*]. > > Yeah, I had started with kvm_mmu_paging_flags, but cpu_flags was an even > worse method than kvm_mmu_paging_mode. We could always do s/is_guest_mode/is_nested_mode or something to that effect. It would take some retraining, but I feel like we've been fighting the whole "guest mode" thing over and over. > Anyway, now that I have done _some_ replacement, it's a matter of sed -i on > the patch files once you or someone else come up with a good moniker. > > I take it that "root_role" passed your filter successfully. Yep, works for me. I almost suggested it, too, but decided I liked mmu_role marginally better. I like root_role because it ties in with root_hpa and root_pga.
