Hi, On Thu, Feb 10, 2022 at 05:45:47PM +0000, Alexandru Elisei wrote: > Hi, > > On Thu, Feb 10, 2022 at 05:25:46PM +0000, Sean Christopherson wrote: > > On Thu, Feb 10, 2022, Alexandru Elisei wrote: > > > I renamed --target-efi to --efi-payload in the last patch because I felt it > > > looked rather confusing to do ./configure --target=qemu --target-efi when > > > configuring the tests. If the rename is not acceptable, I can think of a > > > few other options: > > > > I find --target-efi to be odd irrespective of this new conflict. A simple --efi > > seems like it would be sufficient. I missed this bit in my earlier reply, I like --efi better. I would also like to hear the opinion of the people who added EFI support before reworking the patch. > > > > > 1. Rename --target to --vmm. That was actually the original name for the > > > option, but I changed it because I thought --target was more generic and > > > that --target=efi would be the way going forward to compile kvm-unit-tests > > > to run as an EFI payload. I realize now that separating the VMM from > > > compiling kvm-unit-tests to run as an EFI payload is better, as there can > > > be multiple VMMs that can run UEFI in a VM. Not many people use kvmtool as > > > a test runner, so I think the impact on users should be minimal. > > > > Again irrespective of --target-efi, I think --target for the VMM is a potentially > > confusing name. Target Triplet[*] and --target have specific meaning for the > > compiler, usurping that for something similar but slightly different is odd. > > Wouldn't that mean that --target-efi is equally confusing? Do you have > suggestions for other names? Thanks, Alex
