On Sun, Dec 20, 2009 at 04:23:38PM +0200, Avi Kivity wrote: > On 12/20/2009 04:20 PM, Gleb Natapov wrote: > >+ > >>+ if (create_l1_state(vcpu)) { > >>+ printk(KERN_ERR "%s create_l1_state failed\n", __func__); > >>+ kvm_queue_exception(vcpu, UD_VECTOR); > >Should we send UD exception if there is internal error? May be doing > >VMfailinvalid would be more appropriate? Also this function doesn't handle > >all errors (address alignment, version checking, register operand). > > > Host errors like -ENOMEM should propagate to the return code of ioctl(). > Yes, even better. -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html