On Wed, Feb 02, 2022 at 11:28:01AM -0600, Michael Roth wrote: > Indeed... it looks like linux/{elf,io,efi,acpi}.h all end up pulling in > kernel proper's rdmsr()/wrmsr() definitions, and pulling them out ends up > breaking a bunch of other stuff, It's a nightmare - just gave it a try. No wonder they call it include hell. > so I think we might be stuck using a different name like > rd_msr()/wr_msr() in the meantime. Ok, but then pls call them boot_rdmsr() and boot_wrmsr() so that there's a clear distinction from all the other msr helpers. And put a comment above them in arch/x86/boot/msr.h explaining why they're called this way. One fine day I'll have this mess untangled and clean... Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette