On 1/19/22 18:44, Sean Christopherson wrote:
I think we can fix that usage though:
https://lore.kernel.org/all/YcTpJ369cRBN4W93@xxxxxxxxxx
Ok, will review next week.
So either we have another special case to document for the dirty ring
buffer (and retroactively so, even), or we're in bad need for a solution.
Seems like adding that warning is having precisely the desired effect:)
The WARN is certainly useful. Part of me actually likes the restriction of needing
to have a valid vCPU, at least for x86, as there really aren't many legitimate cases
where KVM should be marking memory dirty without a vCPU.
Yes, I agree that every case of it has needed, at the very least,
further scrutiny.
Paolo
