Re: [PATCH 1/2] kvm: selftests: Sync KVM_CAP_XSAVE2 from linux header

Yang Zhong <yang.zhong@xxxxxxxxx> · Wed, 19 Jan 2022 09:51:53 +0800

On Tue, Jan 18, 2022 at 04:54:51PM +0000, Sean Christopherson wrote:
> On Tue, Jan 18, 2022, Yang Zhong wrote:
> > Need sync KVM_CAP_XSAVE2 from linux header to here.
> > 
> > Signed-off-by: Yang Zhong <yang.zhong@xxxxxxxxx>
> > ---
> >  tools/include/uapi/linux/kvm.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/include/uapi/linux/kvm.h b/tools/include/uapi/linux/kvm.h
> > index f066637ee206..63b96839186c 100644
> > --- a/tools/include/uapi/linux/kvm.h
> > +++ b/tools/include/uapi/linux/kvm.h
> > @@ -1131,7 +1131,7 @@ struct kvm_ppc_resize_hpt {
> >  #define KVM_CAP_EXIT_ON_EMULATION_FAILURE 204
> >  #define KVM_CAP_ARM_MTE 205
> >  #define KVM_CAP_VM_MOVE_ENC_CONTEXT_FROM 206
> > -#define KVM_CAP_XSAVE2 207
> > +#define KVM_CAP_XSAVE2 208
> 
> Any reason not to opportunistically sync the entire file?  E.g. this diff looks
> rather confusing without pulling in KVM_CAP_VM_GPA_BITS (that consumes "207").
> 

  Thanks Sean, I checked this file history, Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>,
  who always sync this header with kernel source, so maybe much better if he can do this.

  Please ignore this patch and help review patch 2, thanks!

  Yang

> >  
> >  #ifdef KVM_CAP_IRQ_ROUTING
> >  