On 1/17/22 10:38 AM, Thomas Huth wrote:
On 14/01/2022 21.38, Matthew Rosato wrote:
Use the associated vfio feature ioctl to enable interpretation for
devices
when requested. As part of this process, we must use the host function
handle rather than a QEMU-generated one -- this is provided as part of
the
ioctl payload.
Signed-off-by: Matthew Rosato <mjrosato@xxxxxxxxxxxxx>
---
hw/s390x/s390-pci-bus.c | 70 +++++++++++++++++++++++++++++++-
hw/s390x/s390-pci-inst.c | 63 +++++++++++++++++++++++++++-
hw/s390x/s390-pci-vfio.c | 52 ++++++++++++++++++++++++
include/hw/s390x/s390-pci-bus.h | 1 +
include/hw/s390x/s390-pci-vfio.h | 15 +++++++
5 files changed, 199 insertions(+), 2 deletions(-)
diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index 01b58ebc70..a39ccfee05 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
...
@@ -1360,6 +1427,7 @@ static Property s390_pci_device_properties[] = {
DEFINE_PROP_UINT16("uid", S390PCIBusDevice, uid, UID_UNDEFINED),
DEFINE_PROP_S390_PCI_FID("fid", S390PCIBusDevice, fid),
DEFINE_PROP_STRING("target", S390PCIBusDevice, target),
+ DEFINE_PROP_BOOL("interp", S390PCIBusDevice, interp, true),
DEFINE_PROP_END_OF_LIST(),
};
Since this is something that the user can see, would it maybe make sense
to provide a full word instead of an abbreviation here? I.e. "interpret"
or "interpretation" instead of "interp" ?
I'll go with "interpret" unless someone else has a strong opinion on it.
