On Tue, Jan 18, 2022 at 8:51 AM Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: > > On 11/16/21 21:40, Zixuan Wang wrote: > > Hello, > > > > This patch series refactors the x86_64 UEFI set up process, fixes the > > `run-tests.sh` script to run under UEFI, and improves the boot speed > > under UEFI. The patches are organized as four parts. > > > > The first part (patches 1-3) refactors the x86_64 UEFI set up process. > > The previous UEFI setup calls arch-specific setup functions twice and > > generates arch-specific data structure. As Andrew suggested [1], we > > refactor this process to make only one call to the arch-specific > > function and generate arch-neutral data structures. This simplifies the > > set up process and makes it easier to develop UEFI support for other > > architectures. > > > > The second part (patch 4) converts several x86 test cases to > > position-independent code (PIC) to run under UEFI. This patch is ported > > from the initial UEFI support patchset [2] with fixes to the 32-bit > > compilation. > > > > The third part (patches 5-8) fixes the UEFI runner scripts. Patch 5 > > sets UEFI OVMF image as read-only. Patch 6 fixes test cases' return > > code under UEFI, enabling Patch 7-8 to fix the `run-tests.sh` script > > under UEFI. > > > > The fourth part (patches 9-10) improves the boot speed under UEFI. > > Patch 9 renames the EFI executables to EFI/BOOT/BOOTX64.EFI. UEFI OVMF > > recognizes this file by default and skips the 5-second user input > > waiting. Patch 10 makes `run-tests.sh` work with this new EFI > > executable filename. > > > > This patchset is based on the `uefi` branch. > > Hi, I have now merged this series and the uefi branch into master. > > Paolo > Excellent! The change to the last patch looks good to me by the way.