Avi Kivity wrote: > On 12/08/2009 11:17 PM, Jan Kiszka wrote: >> >>> I don't see the need for setting any state in kvm_vcpu_events >>> automatically, on kernel entry (apparently there was consensus that >>> saving similar state explicitly in qemu was the way to go). >>> >> (I don't think so. IMHO the cleaner way is to avoid loading critical >> states unless we are resetting or vmloading.) >> >> > > I now agree. But instead of SCOPE_RESET and SCOPE_RUNTIME (or whatever > that was), how about SCOPE_GPR, SCOPE_FPU, SCOPE_SREGS etc. That means > the backing code in kvm.c doesn't have to know what qemu is interested > in wrt SCOPE_RESET, and it's easier for readers to infer what is meant. That's not my idea. I want to be able to state the scope in generic, arch-independent, KVM-unaware code. What the scope actually means /wrt writeback should only be defined in the arch-specific kvm service implementing it. Your suggestion would go in the wrong direction IMO. Jan
Attachment:
signature.asc
Description: OpenPGP digital signature
