On 1/13/2022 2:59 AM, Sean Christopherson wrote: > +Aaron, and +Paolo who may or may not subsribe to kvm@ :-) > > On Wed, Dec 29, 2021, Manali Shukla wrote: >> This series adds 3 KVM Unit tests for nested SVM >> 1) Check #NM is handled in L2 when L2 #NM handler is registered >> "fnop" instruction is called in L2 to generate the exception >> >> 2) Check #BP is handled in L2 when L2 #BP handler is registered >> "int3" instruction is called in L2 to generate the exception >> >> 3) Check #OF is handled in L2 when L2 #OF handler is registered >> "into" instruction with instrumented code is used in L2 to >> generate the exception > > This is all basically identical in terms of desired functionality to existing or > in-flight nVMX tests, e.g. vmx_nm_test() and Aaron's vmx_exception_test() work[*]. > And much of the feedback I provided to Aaron's earlier revisions applies to this > series as well, e.g. create a framework to test intercpetion of arbitrary exceptions > instead of writing the same boilerplate for each and every test. > > It doesn't seem like it'd be _that_ difficult to turn vmx_exception_test into a > generic-ish l2_exception_test. To avoid too much scope creep, what if we first get > Aaron's code merged, and than attempt to extract the core functionality into a > shared library to reuse it for nSVM? If it turns out to be more trouble then its > worth, we can always fall back to something like this series. > > [*] https://lore.kernel.org/all/20211214011823.3277011-1-aaronlewis@xxxxxxxxxx This patch has already been queued by Paolo. I will wait till Aaron's code is merged and than do appropriate changes. I hope this is fine. Thank you Manali
