[PATCH kvmtool 3/5] virtio/net: Warn if virtio_net is implicitly enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The virtio_net device is implicitly enabled if user doesn't
explicitly specify that virtio_net is disabled. This is
counter-intuitive to how the rest of the virtio commandline
works.

For backwards-compatibility, the commandline parameters are
not changed. Instead, this patch prints out a warning if
virtio_net is implicitly enabled.

Signed-off-by: Martin Radev <martin.b.radev@xxxxxxxxx>
---
 virtio/net.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/virtio/net.c b/virtio/net.c
index 9a25bfa..ab75d40 100644
--- a/virtio/net.c
+++ b/virtio/net.c
@@ -1002,6 +1002,9 @@ int virtio_net__init(struct kvm *kvm)
 
 	if (kvm->cfg.num_net_devices == 0 && kvm->cfg.no_net == 0) {
 		static struct virtio_net_params net_params;
+		pr_warning(
+			"No net devices configured, but no_net not specified. "
+			"Enabling virtio_net with default network settings...\n");
 
 		net_params = (struct virtio_net_params) {
 			.guest_ip	= kvm->cfg.guest_ip,
-- 
2.25.1




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux