On 12/15/2009 02:24 PM, Marcelo Tosatti wrote:
This patch essentially revers commit 898c51c3. This commit fixes two races. First race is like this: vcpu0 vcpu1 starts running loads lapic state into kernel sends event to vcpu1 starts running loads lapic state into kernel overwrites event from vcpu0 At the time 898c51c3 was committed the race was easily reproducible by starting VM with 16 cpus + seabios. Sometimes some vcpus lost INIT/SIPI events. Now I am not able to reproduce it even with this patch applied, so something else changed, but it doesn't make the race non existent or acceptable.Note qemu_kvm_load_lapic depends on env->created set (kvm_vcpu_inited), so having init_vcpu+load_regs before signalling vcpu creation did not fix this one (but yeah, thanks for the reminder on the races).
So safest to revert and wait for a fixed patch? -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
