On Tue, Jan 11, 2022 at 2:23 AM Marc Zyngier <maz@xxxxxxxxxx> wrote: > > On Mon, 10 Jan 2022 21:04:39 +0000, > Jing Zhang <jingzhangos@xxxxxxxxxx> wrote: > > > > To reduce the contentions caused by MMU lock, some MMU operations can > > be performed under read lock. > > One improvement is to add a fast path for permission relaxation during > > dirty logging under the read lock. > > This commit message really doesn't say what this patch does > (converting our MMU spinlock to a rwlock, and replacing all instances > of the lock being acquired with a write lock acquisition). Crucially, > it only mention the read lock which appears *nowhere* in this patch. > Good point. Will use the below message instead for future posts. "Replace MMU spinlock with rwlock and update all instances of the lock being acquired with a write lock acquisition. Future commit will add a fast path for permission relaxation during dirty logging under a read lock." > Thanks, > > M. > > -- > Without deviation from the norm, progress is not possible. Thanks, Jing
