On Mon, 10 Jan 2022 21:04:41 +0000, Jing Zhang <jingzhangos@xxxxxxxxxx> wrote: > > For ARM64, if no vgic is setup before the dirty log perf test, the > userspace irqchip would be used, which would affect the dirty log perf > test result. Doesn't it affect *all* performance tests? How much does this change contributes to the performance numbers you give in the cover letter? > > Signed-off-by: Jing Zhang <jingzhangos@xxxxxxxxxx> > --- > tools/testing/selftests/kvm/dirty_log_perf_test.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/tools/testing/selftests/kvm/dirty_log_perf_test.c b/tools/testing/selftests/kvm/dirty_log_perf_test.c > index 1954b964d1cf..b501338d9430 100644 > --- a/tools/testing/selftests/kvm/dirty_log_perf_test.c > +++ b/tools/testing/selftests/kvm/dirty_log_perf_test.c > @@ -18,6 +18,12 @@ > #include "test_util.h" > #include "perf_test_util.h" > #include "guest_modes.h" > +#ifdef __aarch64__ > +#include "aarch64/vgic.h" > + > +#define GICD_BASE_GPA 0x8000000ULL > +#define GICR_BASE_GPA 0x80A0000ULL How did you pick these values? Thanks, M. -- Without deviation from the norm, progress is not possible.