Hi Marc, On 1/7/22 5:33 PM, Marc Zyngier wrote: > Now that the devices present in the extended memory map are checked > against the available PA space and disabled when they don't fit, > there is no need to keep the same checks against highmem, as > highmem really is a shortcut for the PA space being 32bit. > > Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx> Reviewed-by: Eric Auger <eric.auger@xxxxxxxxxx> Thanks Eric > --- > hw/arm/virt-acpi-build.c | 2 -- > hw/arm/virt.c | 5 +---- > 2 files changed, 1 insertion(+), 6 deletions(-) > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > index 505c61e88e..cdac009419 100644 > --- a/hw/arm/virt-acpi-build.c > +++ b/hw/arm/virt-acpi-build.c > @@ -946,8 +946,6 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTables *tables) > acpi_add_table(table_offsets, tables_blob); > build_fadt_rev5(tables_blob, tables->linker, vms, dsdt); > > - vms->highmem_redists &= vms->highmem; > - > acpi_add_table(table_offsets, tables_blob); > build_madt(tables_blob, tables->linker, vms); > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 70b4773b3e..641c6a9c31 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -2170,9 +2170,6 @@ static void machvirt_init(MachineState *machine) > > virt_flash_fdt(vms, sysmem, secure_sysmem ?: sysmem); > > - vms->highmem_mmio &= vms->highmem; > - vms->highmem_redists &= vms->highmem; > - > create_gic(vms, sysmem); > > virt_cpu_post_init(vms, sysmem); > @@ -2191,7 +2188,7 @@ static void machvirt_init(MachineState *machine) > machine->ram_size, "mach-virt.tag"); > } > > - vms->highmem_ecam &= vms->highmem && (!firmware_loaded || aarch64); > + vms->highmem_ecam &= (!firmware_loaded || aarch64); > > create_rtc(vms); >
