> From: Borislav Petkov <bp@xxxxxxxxx> > Sent: Saturday, January 8, 2022 3:44 AM > > On Fri, Jan 07, 2022 at 01:54:56PM -0500, Paolo Bonzini wrote: > > From: Jing Liu <jing2.liu@xxxxxxxxx> > > > > vCPU threads are different from native tasks regarding to the initial XFD > > value. While all native tasks follow a fixed value (init_fpstate::xfd) > > established by the FPU core at boot, vCPU threads need to obey the reset > > value (i.e. ZERO) defined by the specification, to meet the expectation of > > the guest. > > > > Let the caller supply an argument and adjust the host and guest related > > invocations accordingly. > > > > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > > If Jing is author, then tglx's SOB should come after Jing's to mean, > tglx handled it further. > > As it is now, it looks wrong. Thanks for pointing it out! Actually this is one area which we didn't get a clear answer from 'submitting-patches.rst' and now possibly a good chance to get it clarified. This patch was handled in an interesting way due to Jing's two absences: Internal version: Jing was the original author Signed-off-by: Jing Liu <jing2.liu@xxxxxxxxx> --- Jing's first absence --- v1: Yang was the submitter: Signed-off-by: Jing Liu <jing2.liu@xxxxxxxxx> Signed-off-by: Yang Zhong <yang.zhong@xxxxxxxxx> Thomas updated it in his personal branch when reviewing v1: From: Jing Liu <jing2.liu@xxxxxxxxx> Signed-off-by: Jing Liu <jing2.liu@xxxxxxxxx> Signed-off-by: Yang Zhong <yang.zhong@xxxxxxxxx> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> --- Jing was back --- v2-v3: Jing was the submitter: The open here is whether Jing should change the SoB order: Signed-off-by: Yang Zhong <yang.zhong@xxxxxxxxx> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> Signed-off-by: Jing Liu <jing2.liu@xxxxxxxxx> or just append her name again: Signed-off-by: Jing Liu <jing2.liu@xxxxxxxxx> Signed-off-by: Yang Zhong <yang.zhong@xxxxxxxxx> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> Signed-off-by: Jing Liu <jing2.liu@xxxxxxxxx> The former was selected for this patch. --- Jing's 2nd absence --- v4-v5: Yang was the submitter. SoB order was partially changed (for Yang's SoB) but forgot to make Jing's SoB as the first. It should be: From: Jing Liu <jing2.liu@xxxxxxxxx> Signed-off-by: Jing Liu <jing2.liu@xxxxxxxxx> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> Signed-off-by: Yang Zhong <yang.zhong@xxxxxxxxx> If the rule is that SoB order should not be changed, then it will be: From: Jing Liu <jing2.liu@xxxxxxxxx> Signed-off-by: Jing Liu <jing2.liu@xxxxxxxxx> Signed-off-by: Yang Zhong <yang.zhong@xxxxxxxxx> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> Signed-off-by: Jing Liu <jing2.liu@xxxxxxxxx> Signed-off-by: Yang Zhong <yang.zhong@xxxxxxxxx> > > Ditto for patches 10, 11, 12, 13. > > Also, I wonder if all those Signed-off-by's do mean "handled" or > Co-developed-by but I haven't tracked that particular pile so... > > > Signed-off-by: Jing Liu <jing2.liu@xxxxxxxxx> > > Signed-off-by: Yang Zhong <yang.zhong@xxxxxxxxx> > > Message-Id: <20220105123532.12586-6-yang.zhong@xxxxxxxxx> > > Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx> > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette
