On Tue, May 11, 2021 at 11:33 PM Like Xu <like.xu@xxxxxxxxxxxxxxx> wrote: > > On 2021/5/12 5:27, Jim Mattson wrote: > > On Fri, May 29, 2020 at 12:44 AM Like Xu <like.xu@xxxxxxxxxxxxxxx> wrote: > >> > >> When the full-width writes capability is set, use the alternative MSR > >> range to write larger sign counter values (up to GP counter width). > >> > >> Signed-off-by: Like Xu <like.xu@xxxxxxxxxxxxxxx> > >> --- > > > >> + /* > >> + * MSR_IA32_PMCn supports writing values ​​up to GP counter width, > >> + * and only the lowest bits of GP counter width are valid. > >> + */ > > > > Could you rewrite this comment in ASCII, please? I would do it, but > > I'm not sure what the correct translation is. > > > > My first submitted patch says that > they are just Unicode "ZERO WIDTH SPACE". > > https://lore.kernel.org/kvm/20200508083218.120559-2-like.xu@xxxxxxxxxxxxxxx/ > > Here you go: > > --- > > From 1b058846aabcd7a85b5c5f41cb2b63b6a348bdc4 Mon Sep 17 00:00:00 2001 > From: Like Xu <like.xu@xxxxxxxxxxxxxxx> > Date: Wed, 12 May 2021 14:26:40 +0800 > Subject: [PATCH] x86: pmu: Fix a comment about full-width counter writes > support > > Remove two Unicode characters 'ZERO WIDTH SPACE' (U+200B). > > Fixes: 22f2901a0e ("x86: pmu: Test full-width counter writes support") > Reported-by: Jim Mattson <jmattson@xxxxxxxxxx> > Signed-off-by: Like Xu <like.xu@xxxxxxxxxxxxxxx> > --- > x86/pmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/x86/pmu.c b/x86/pmu.c > index 5a3d55b..6cb3506 100644 > --- a/x86/pmu.c > +++ b/x86/pmu.c > @@ -510,7 +510,7 @@ static void check_gp_counters_write_width(void) > } > > /* > - * MSR_IA32_PMCn supports writing values ​​up to GP > counter width, > + * MSR_IA32_PMCn supports writing values up to GP counter width, > * and only the lowest bits of GP counter width are valid. > */ > for (i = 0; i < num_counters; i++) { > -- > 2.31.1 Paolo: Did this patch get overlooked? I'm still seeing the unicode characters in this comment.
