On Wed, Jan 05, 2022, David Matlack wrote: > > I don't even see anywhere that the tdp mmu disables the EXEC bit for 4K.. if > > that's true then perhaps we can even drop "access" and this check? But I could > > have missed something. > > TDP MMU always passes ACC_ALL so the access check could be omitted > from this patch. But it will be needed to support eager splitting for > the shadow MMU, which does not always allow execution. Sure, but let's add that complexity when it's needed. That also has the advantage of documenting, in git history, why the param is in needed.
