On Thu, Jan 06, 2022 at 10:20:51AM +0800, Lu Baolu wrote:
> Ordinary drivers should use iommu_attach/detach_device() for domain
> attaching and detaching.
>
> Signed-off-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> drivers/gpu/host1x/dev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c
> index fbb6447b8659..6e08cb6202cc 100644
> +++ b/drivers/gpu/host1x/dev.c
> @@ -265,7 +265,7 @@ static struct iommu_domain *host1x_iommu_attach(struct host1x *host)
> goto put_cache;
> }
>
> - err = iommu_attach_group(host->domain, host->group);
> + err = iommu_attach_device(host->domain, host->dev);
> if (err) {
> if (err == -ENODEV)
> err = 0;
> @@ -335,7 +335,7 @@ static void host1x_iommu_exit(struct host1x *host)
> {
> if (host->domain) {
> put_iova_domain(&host->iova);
> - iommu_detach_group(host->domain, host->group);
> + iommu_detach_device(host->domain, host->dev);
>
> iommu_domain_free(host->domain);
> host->domain = NULL;
Shouldn't this add the flag to tegra_host1x_driver ?
And do like we did in the other tegra stuff and switch to the dma api
when !host1x_wants_iommu() ?
Jason
