On Tue, Jan 4, 2022 at 2:32 AM Peter Xu <peterx@xxxxxxxxxx> wrote: > > On Mon, Dec 13, 2021 at 10:59:09PM +0000, David Matlack wrote: > > +/* > > + * tdp_mmu_install_sp_atomic - Atomically replace the given spte with an > > + * spte pointing to the provided page table. > > + * > > + * @kvm: kvm instance > > + * @iter: a tdp_iter instance currently on the SPTE that should be set > > + * @sp: The new TDP page table to install. > > + * @account_nx: True if this page table is being installed to split a > > + * non-executable huge page. > > + * > > + * Returns: True if the new page table was installed. False if spte being > > + * replaced changed, causing the atomic compare-exchange to fail. > > + * If this function returns false the sp will be freed before > > s/will/will not/? Good catch. This comment is leftover from the RFC patch where it did free the sp. > > > + * returning. > > + */ > > -- > Peter Xu >
