Re: [PATCH v17 01/15] s390/vfio-ap: Set pqap hook when vfio_ap module is loaded

["Jason J. Herne" <jjherne@xxxxxxxxxxxxx>]

On 10/21/21 11:23, Tony Krowiak wrote:

> diff --git a/arch/s390/include/asm/kvm_host.h b/arch/s390/include/asm/kvm_host.h
> index a604d51acfc8..05569d077d7f 100644
> --- a/arch/s390/include/asm/kvm_host.h
> +++ b/arch/s390/include/asm/kvm_host.h
> @@ -799,16 +799,17 @@ struct kvm_s390_cpu_model {
>   	unsigned short ibc;
>   };
>   
> -typedef int (*crypto_hook)(struct kvm_vcpu *vcpu);
> +struct kvm_s390_crypto_hook {
> +	int (*fcn)(struct kvm_vcpu *vcpu);
> +};

Why are we storing a single function pointer inside a struct? Seems simpler to just use a 
function pointer. What was the problem with the typedef that you are replacing?