Re: [PATCH 11/12] s390x/pci: use dtsm provided from vfio capabilities for interpreted devices

[Pierre Morel <pmorel@xxxxxxxxxxxxx>]

On 12/7/21 22:04, Matthew Rosato wrote:
> When using the IOAT assist via interpretation, we should advertise what
> the host driver supports, not QEMU.
>
> Signed-off-by: Matthew Rosato <mjrosato@xxxxxxxxxxxxx>
> ---
>   hw/s390x/s390-pci-vfio.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/hw/s390x/s390-pci-vfio.c b/hw/s390x/s390-pci-vfio.c
> index 6fc03a858a..c9269683f5 100644
> --- a/hw/s390x/s390-pci-vfio.c
> +++ b/hw/s390x/s390-pci-vfio.c
> @@ -336,7 +336,11 @@ static void s390_pci_read_group(S390PCIBusDevice *pbdev,
>           resgrp->i = cap->noi;
>           resgrp->maxstbl = cap->maxstbl;
>           resgrp->version = cap->version;
> -        resgrp->dtsm = ZPCI_DTSM;
> +        if (hdr->version >= 2 && pbdev->interp) {
> +            resgrp->dtsm = cap->dtsm;
> +        } else {
> +            resgrp->dtsm = ZPCI_DTSM;
> +        }
>       }
>   }
>   
Reviewed-by: Pierre Morel <pmorel@xxxxxxxxxxxxx>

--
Pierre Morel
IBM Lab Boeblingen