Re: [PATCH 17/15] KVM: X86: Ensure pae_root to be reconstructed for shadow paging if the guest PDPTEs is changed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 17/15] KVM: X86: Ensure pae_root to be reconstructed for shadow paging if the guest PDPTEs is changed
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Sat, 11 Dec 2021 09:22:15 +0100
Cc: Lai Jiangshan <jiangshanlai@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, Lai Jiangshan <laijs@xxxxxxxxxxxxxxxxx>, Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>, Wanpeng Li <wanpengli@xxxxxxxxxxx>, Jim Mattson <jmattson@xxxxxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, x86@xxxxxxxxxx, "H. Peter Anvin" <hpa@xxxxxxxxx>, Xiao Guangrong <guangrong.xiao@xxxxxxxxxxxxxxx>
In-reply-to: <42701fedbe10acf164ec56818b941061be6ffd4e.camel@redhat.com>
References: <20211108124407.12187-1-jiangshanlai@gmail.com> <20211111144634.88972-1-jiangshanlai@gmail.com> <Ya/5MOYef4L4UUAb@google.com> <11219bdb-669c-cf6f-2a70-f4e5f909a2ad@redhat.com> <YbPBjdAz1GQGr8DT@google.com> <42701fedbe10acf164ec56818b941061be6ffd4e.camel@redhat.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0

On 12/11/21 07:56, Maxim Levitsky wrote:

This apparently wasn't validated against a simple use case, let
alone against things like migration with nested VMs, multliple L2s,
etc...


I did validate the *SREGS2* against all the cases I could (like
migration, EPT/NPT disabled/etc. I even started testing SMM to see
how it affects PDPTRs, and patched seabios to use PAE paging. I still
could have missed something.


Don't worry, I think Sean was talking about patch 16 and specifically
digging at me (who deserved it completely).

Paolo

Follow-Ups:
- Re: [PATCH 17/15] KVM: X86: Ensure pae_root to be reconstructed for shadow paging if the guest PDPTEs is changed
  - From: Sean Christopherson

References:
- [PATCH 00/15] KVM: X86: Fix and clean up for register caches
  - From: Lai Jiangshan
- [PATCH 17/15] KVM: X86: Ensure pae_root to be reconstructed for shadow paging if the guest PDPTEs is changed
  - From: Lai Jiangshan
- Re: [PATCH 17/15] KVM: X86: Ensure pae_root to be reconstructed for shadow paging if the guest PDPTEs is changed
  - From: Sean Christopherson
- Re: [PATCH 17/15] KVM: X86: Ensure pae_root to be reconstructed for shadow paging if the guest PDPTEs is changed
  - From: Paolo Bonzini
- Re: [PATCH 17/15] KVM: X86: Ensure pae_root to be reconstructed for shadow paging if the guest PDPTEs is changed
  - From: Sean Christopherson
- Re: [PATCH 17/15] KVM: X86: Ensure pae_root to be reconstructed for shadow paging if the guest PDPTEs is changed
  - From: Maxim Levitsky

Prev by Date: Re: [PATCH v11 kvmtool 0/8] KVMTOOL RISC-V Support
Next by Date: Re: Potential bug in TDP MMU
Previous by thread: Re: [PATCH 17/15] KVM: X86: Ensure pae_root to be reconstructed for shadow paging if the guest PDPTEs is changed
Next by thread: Re: [PATCH 17/15] KVM: X86: Ensure pae_root to be reconstructed for shadow paging if the guest PDPTEs is changed
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]