On Wed, Dec 09, 2009 at 09:20:49PM +0200, Gleb Natapov wrote: > On Wed, Dec 09, 2009 at 03:46:54PM -0200, Marcelo Tosatti wrote: > > > > Otherwise a zero apic base is loaded into KVM, which results > > in interrupts being lost until a proper apic base with enabled > > bit set is loaded. > > > > Fixes WinXP migration in qemu-kvm origin/next. > > > > Signed-off-by: Marcelo Tosatti <mtosatti@xxxxxxxxxx> > > > > diff --git a/hw/apic.c b/hw/apic.c > > index 627ff98..45a4d2b 100644 > > --- a/hw/apic.c > > +++ b/hw/apic.c > > @@ -1131,6 +1131,11 @@ int apic_init(CPUState *env) > > vmstate_register(s->idx, &vmstate_apic, s); > > qemu_register_reset(apic_reset, s); > > > > + /* apic_reset must be called before the vcpu threads are initialized and load > > + * registers, in qemu-kvm. > > + */ > > + apic_reset(s); > > + > > local_apics[s->idx] = s; > > return 0; > > } > Didn't calls to reset90 were removed from init functions to be done in > centralized manner? Yes, but apic reset (which initialiazes the reset lapic values) conflicts with qemu-kvm's creation of vcpu threads. qemu upstream is fine. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
