Re: qemu-kvm requires apic initialized before vcpu main loop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 09, 2009 at 03:46:54PM -0200, Marcelo Tosatti wrote:
> 
> Otherwise a zero apic base is loaded into KVM, which results
> in interrupts being lost until a proper apic base with enabled 
> bit set is loaded.
> 
> Fixes WinXP migration in qemu-kvm origin/next.
> 
> Signed-off-by: Marcelo Tosatti <mtosatti@xxxxxxxxxx>
> 
> diff --git a/hw/apic.c b/hw/apic.c
> index 627ff98..45a4d2b 100644
> --- a/hw/apic.c
> +++ b/hw/apic.c
> @@ -1131,6 +1131,11 @@ int apic_init(CPUState *env)
>      vmstate_register(s->idx, &vmstate_apic, s);
>      qemu_register_reset(apic_reset, s);
>  
> +    /* apic_reset must be called before the vcpu threads are initialized and load 
> +     * registers, in qemu-kvm.
> +     */
> +    apic_reset(s);
> +
But by doing this, the system-wide reset will re-reset the apic, possibly losing
some other information.

Also, system_reset happens before we signal system_ready (or at least should).
This means the vcpus should not be running and producing anything useful yet.
So how does it happen, in the first place?
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux