Hi Joerg, On 12/6/21 11:48 AM, Joerg Roedel wrote: > On Wed, Oct 27, 2021 at 12:44:20PM +0200, Eric Auger wrote: >> Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@xxxxxxx> >> Signed-off-by: Liu, Yi L <yi.l.liu@xxxxxxxxxxxxxxx> >> Signed-off-by: Ashok Raj <ashok.raj@xxxxxxxxx> >> Signed-off-by: Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx> >> Signed-off-by: Eric Auger <eric.auger@xxxxxxxxxx> > This Signed-of-by chain looks dubious, you are the author but the last > one in the chain? The 1st RFC in Aug 2018 (https://lists.cs.columbia.edu/pipermail/kvmarm/2018-August/032478.html) said this was a generalization of Jacob's patch [PATCH v5 01/23] iommu: introduce bind_pasid_table API function https://lists.linuxfoundation.org/pipermail/iommu/2018-May/027647.html So indeed Jacob should be the author. I guess the multiple rebases got this eventually replaced at some point, which is not an excuse. Please forgive me for that. Now the original patch already had this list of SoB so I don't know if I shall simplify it. > >> +int iommu_uapi_attach_pasid_table(struct iommu_domain *domain, >> + void __user *uinfo) >> +{ > [...] > >> + if (pasid_table_data.format == IOMMU_PASID_FORMAT_SMMUV3 && >> + pasid_table_data.argsz < >> + offsetofend(struct iommu_pasid_table_config, vendor_data.smmuv3)) >> + return -EINVAL; > This check looks like it belongs in driver specific code. Indeed, I will fix that in my next respin :-) Thanks! Eric > > Regards, > > Joerg >
