On Mon, Dec 06, 2021 at 06:13:01AM -0800, Christoph Hellwig wrote: > On Mon, Dec 06, 2021 at 08:53:07AM +0100, Greg Kroah-Hartman wrote: > > On Mon, Dec 06, 2021 at 09:58:48AM +0800, Lu Baolu wrote: > > > The platform_dma_configure() is shared between platform and amba bus > > > drivers. Rename the common helper to firmware_dma_configure() so that > > > both platform and amba bus drivers could customize their dma_configure > > > callbacks. > > > > Please, if you are going to call these functions "firmware_" then move > > them to the drivers/firmware/ location, they do not belong in > > drivers/base/platform.c anymore, right? > > firmware seems rather misnamed anyway, amba doesn't reall have anything > to do with "firmware". Then the name is not a good one and should be called something else :)
