Re: [kvm-unit-tests PATCH v1 1/2] s390x: make smp_cpu_setup() return 0 on success

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/2/21 10:58, David Hildenbrand wrote:
Properly return "0" on success so callers can check if the setup was
successful.

The return value is yet unused, which is why this wasn't noticed so far.

Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
---
  lib/s390x/smp.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/lib/s390x/smp.c b/lib/s390x/smp.c
index da6d32f..b753eab 100644
--- a/lib/s390x/smp.c
+++ b/lib/s390x/smp.c
@@ -212,6 +212,7 @@ int smp_cpu_setup(uint16_t addr, struct psw psw)
  	/* Wait until the cpu has finished setup and started the provided psw */
  	while (lc->restart_new_psw.addr != psw.addr)
  		mb();
+	rc = 0;
  out:
  	spin_unlock(&lock);
  	return rc;


oops

Reviewed-by: Janosch Frank <frankja@xxxxxxxxxxxxx>



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux