Re: [PATCH] qemu-kvm: x86: Fix mismerge in cpu_post_load

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Dec 06, 2009 at 11:39:22AM +0100, Jan Kiszka wrote:
> >> Unlike the other states we discussed, this one
> >> is not "fixable" in the kernel. So I tend to think there is a real need
> >> for my write-back scope abstraction - which would also be able to handle
> >> the other states cleanly, both in upstream and here.
> >>    
> > 
> > Yes.  Gleb suggested treating mpstate/nmi as part of the APIC state
> > (which makes sense), which would work, as APIC state is not
> > automatically written back.  But the tsc msr would need special treatment.
> 
> (just realized that I forgot to answer him)
> 
> While this would make sense for mpstate, NMIs are not coupled to the
> APICs. The APIC just happens to be one source for them (though a common
> one). So if there is no in-kernel APIC state, there would never be a
> write-back of the NMI state, which is bad.
> 
I agree about NMI. We never do RMW to NMI anyway. Mpstate/sipi_vector belong
to APIC state though.

--
			Gleb.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux