Andrew Jones <drjones@xxxxxxxxxx> writes: > On Thu, Nov 18, 2021 at 06:46:41PM +0000, Alex Bennée wrote: >> Signed-off-by: Alex Bennée <alex.bennee@xxxxxxxxxx> >> --- >> README.md | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/README.md b/README.md >> index b498aaf..5db48e5 100644 >> --- a/README.md >> +++ b/README.md >> @@ -182,3 +182,5 @@ the code files. We also start with common code and finish with unit test >> code. git-diff's orderFile feature allows us to specify the order in a >> file. The orderFile we use is `scripts/git.difforder`; adding the config >> with `git config diff.orderFile scripts/git.difforder` enables it. >> + >> +Please run the kernel's ./scripts/checkpatch.pl on new patches > > This is a bit of a problem for kvm-unit-tests code which still has a mix > of styles since it was originally written with a strange tab and space > mixed style. If somebody is patching one of those files we've usually > tried to maintain the original style rather than reformat the whole > thing (in hindsight maybe we should have just reformatted). We're also > more flexible with line length than Linux, although Linux now only warns > for anything over 80 as long as it's under 100, which is probably good > enough for us too. Anyway, let's see what Paolo and Thomas say. Personally > I wouldn't mind adding this line to the documentation, so I'll ack it. > Anyway, we can also ignore our own advise when it suits us :-) > > Acked-by: Andrew Jones <drjones@xxxxxxxxxx> I can make the wording more weaselly: We strive to follow the Linux kernels coding style so it's recommended to run the kernel's ./scripts/checkpatch.pl on new patches. I added this reference because on the older iterations of these test divergence from the kernel coding style was pointed out and I've fixed them in this iteration. > > Thanks, > drew -- Alex Bennée
