QEMU should be written all caps. Normally checkpatch.pl warns when it is not (see commit 9964d8f9422: "checkpatch: Add QEMU specific rule"). Replace Qemu -> QEMU, update the error message to use the more descriptive "Guest Agent" name instead of "GA". Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> --- qga/installer/qemu-ga.wxs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs index 0950e8c6bec..c02e47fc036 100644 --- a/qga/installer/qemu-ga.wxs +++ b/qga/installer/qemu-ga.wxs @@ -40,14 +40,14 @@ <?endif?> <Product - Name="QEMU guest agent" + Name="QEMU Guest Agent" Id="*" UpgradeCode="{EB6B8302-C06E-4BEC-ADAC-932C68A3A98D}" Manufacturer="$(env.QEMU_GA_MANUFACTURER)" Version="$(env.QEMU_GA_VERSION)" Language="1033"> <?if $(var.Arch) = 32 ?> - <Condition Message="Error: 32-bit version of Qemu GA can not be installed on 64-bit Windows.">NOT VersionNT64</Condition> + <Condition Message="Error: 32-bit version of QEMU Guest Agent can not be installed on 64-bit Windows.">NOT VersionNT64</Condition> <?endif?> <Package Manufacturer="$(env.QEMU_GA_MANUFACTURER)" @@ -64,7 +64,7 @@ <Directory Id="TARGETDIR" Name="SourceDir"> <Directory Id="$(var.GaProgramFilesFolder)" Name="QEMU Guest Agent"> - <Directory Id="qemu_ga_directory" Name="Qemu-ga"> + <Directory Id="qemu_ga_directory" Name="QEMU-GA"> <Component Id="qemu_ga" Guid="{908B7199-DE2A-4DC6-A8D0-27A5AE444FEA}"> <File Id="qemu_ga.exe" Name="qemu-ga.exe" Source="$(env.BUILD_DIR)/qga/qemu-ga.exe" KeyPath="yes" DiskId="1"/> <ServiceInstall -- 2.31.1