On Tue, Nov 16, 2021 at 2:50 AM Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: > > Right now, unittests.cfg only supports a single check line. Multiple > checks must be space separated. > > However, the pmu_emulation test does not really need nmi_watchdog=0; > it is only needed by the PMU counters test because Linux reserves one > counter if nmi_watchdog=1, but the pmu_emulation test does not > allocate all counters in the same way. By removing the counters > tests from pmu_emulation, the check on nmi_watchdog=0 can be > removed. Thanks for fixing this. By the way, one of the reasons that we don't expose a virtual PMU to more customers is the conflict with the NMI watchdog. We aren't willing to give up the NMI watchdog on the host, and we don't really want to report a reduced number of general purpose counters to the guest. (On AMD, we *can't* report a reduced number of counters to the guest; the architectural specification doesn't allow it.) We can't be the only ones running with the NMI watchdog enabled. How do others deal with this? Is there any hope of suspending the NMI watchdog while in VMX non-root mode (or guest mode on AMD)? > This also hid a typo for the force_emulation_prefix module parameter, > which is part of the kvm module rather than the kvm_intel module, > so fix that. > > Reported-by: Like Xu <like.xu.linux@xxxxxxxxx> > Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx> Reviewed-by: Jim Mattson <jmattson@xxxxxxxxxx>
