On Thu, 2021-11-11 at 17:16 +0100, Janosch Frank wrote: > On 11/10/21 21:33, Eric Farman wrote: ...snip... > > + case KVM_S390_VCPU_SET_SIGP_BUSY: { > > + int rc; > > + > > + if (!vcpu->kvm->arch.user_sigp_busy) > > + return -EFAULT; > > Huh? > This should be EINVAL, no? Of course; my mistake. > > > + > > + rc = kvm_s390_vcpu_set_sigp_busy(vcpu); > > + VCPU_EVENT(vcpu, 3, "SIGP: CPU %x set busy rc %x", > > vcpu->vcpu_id, rc); > > + > > + return rc; > > + } > > + case KVM_S390_VCPU_RESET_SIGP_BUSY: { > > + if (!vcpu->kvm->arch.user_sigp_busy) > > + return -EFAULT; > > Same > >