Hi Juan, On 11/1/21 23:08, Juan Quintela wrote: > From: Hyman Huang(黄勇) <huangy81@xxxxxxxxxxxxxxx> > > use dirty ring feature to implement dirtyrate calculation. > > introduce mode option in qmp calc_dirty_rate to specify what > method should be used when calculating dirtyrate, either > page-sampling or dirty-ring should be passed. > > introduce "dirty_ring:-r" option in hmp calc_dirty_rate to > indicate dirty ring method should be used for calculation. > > Signed-off-by: Hyman Huang(黄勇) <huangy81@xxxxxxxxxxxxxxx> Just noticing in the git history some commits from your pull request have the author name (from + S-o-b) mojibaked. > Message-Id: <7db445109bd18125ce8ec86816d14f6ab5de6a7d.1624040308.git.huangy81@xxxxxxxxxxxxxxx> > Reviewed-by: Peter Xu <peterx@xxxxxxxxxx> > Reviewed-by: Juan Quintela <quintela@xxxxxxxxxx> > Signed-off-by: Juan Quintela <quintela@xxxxxxxxxx> > --- > qapi/migration.json | 16 +++- > migration/dirtyrate.c | 208 +++++++++++++++++++++++++++++++++++++++-- > hmp-commands.hx | 7 +- > migration/trace-events | 2 + > 4 files changed, 218 insertions(+), 15 deletions(-)