On Mon, Nov 01, 2021 at 11:08:56PM +0100, Juan Quintela wrote:
> From: Hyman Huang(黄勇) <huangy81@xxxxxxxxxxxxxxx>
>
> introduce "DirtyRateMeasureMode" to specify what method should be
> used to calculate dirty rate, introduce "DirtyRateVcpu" to store
> dirty rate for each vcpu.
>
> use union to store stat data of specific mode
>
> Signed-off-by: Hyman Huang(黄勇) <huangy81@xxxxxxxxxxxxxxx>
> Message-Id: <661c98c40f40e163aa58334337af8f3ddf41316a.1624040308.git.huangy81@xxxxxxxxxxxxxxx>
> Reviewed-by: Peter Xu <peterx@xxxxxxxxxx>
> Reviewed-by: Juan Quintela <quintela@xxxxxxxxxx>
> Signed-off-by: Juan Quintela <quintela@xxxxxxxxxx>
> ---
> qapi/migration.json | 30 +++++++++++++++++++++++++++
> migration/dirtyrate.h | 21 +++++++++++++++----
> migration/dirtyrate.c | 48 +++++++++++++++++++++++++------------------
> 3 files changed, 75 insertions(+), 24 deletions(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 9aa8bc5759..94eece16e1 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1731,6 +1731,21 @@
> { 'event': 'UNPLUG_PRIMARY',
> 'data': { 'device-id': 'str' } }
>
> +##
> +# @DirtyRateVcpu:
> +#
> +# Dirty rate of vcpu.
> +#
> +# @id: vcpu index.
> +#
> +# @dirty-rate: dirty rate.
> +#
> +# Since: 6.1
I'm a bit late on the review, since this pull request is already in.
We'll want a followup patch that changes this to mention 6.2, to
correctly match the release that will first have it. Such a followup
is safe during freeze, since it is doc-only.
> +#
> +##
> +{ 'struct': 'DirtyRateVcpu',
> + 'data': { 'id': 'int', 'dirty-rate': 'int64' } }
> +
> ##
> # @DirtyRateStatus:
> #
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
