> > > > > > +#define SEV_FW_REQ_VER_MAJOR 1 > > > +#define SEV_FW_REQ_VER_MINOR 30 > > > > Where does the requirement for this minimum version come from? Maybe > > add a comment? > > > > Edit: Is this for patches later on in the series that exercise SNP? If > > so, I think it would be better to add a check like this in the test > > itself, rather than globally. I happened to test this on a machine > > with a very old PSP FW, 0.22, and the SEV test added in patch #7 seems > > to work fine with this ancient PSP FW. > > Ah, yes, this was mostly for SNP support. I'll implement a separate minimum > version for SEV/SEV-ES. > I want to ask the same thing, I tried to run the sev selftest today and I was blocked by this minimum version number... BTW: I suspect if I want to update the SEV firmware I have to update the BIOS myself? So, it would be good to know what is the actual minimum for SEV. In addition, maybe that's side effect, I see a warning when building the kernel: "module ccp.ko requires firmware amd/amd_sev_fam19h_model0xh.sbin" Maybe I need some hints from you? Or maybe it is just harmless. I did double checked and it looks like I was using either amd_sev_fam17h_model3xh.sbin or amd_sev_fam17h_model0xh.sbin Thanks. -Mingwei
