On 10/27/21 16:04, David Hildenbrand wrote:
> On 27.10.21 15:36, Philippe Mathieu-Daudé wrote:
>> On 10/27/21 14:45, David Hildenbrand wrote:
>>> Let's return the number of free slots instead of only checking if there
>>> is a free slot. Required to support memory devices that consume multiple
>>> memslots.
>>>
>>> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
>>> ---
>>> hw/mem/memory-device.c | 2 +-
>>> hw/virtio/vhost-stub.c | 2 +-
>>> hw/virtio/vhost.c | 4 ++--
>>> include/hw/virtio/vhost.h | 2 +-
>>> 4 files changed, 5 insertions(+), 5 deletions(-)
>>> -bool vhost_has_free_slot(void)
>>> +unsigned int vhost_get_free_memslots(void)
>>> {
>>> return true;
>>
>> return 0;
>
> Oh wait, no. This actually has to be
>
> "return ~0U;" (see real vhost_get_free_memslots())
>
> ... because there is no vhost and consequently no limit applies.
Indeed.
Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
