On Fri, Oct 22, 2021 at 1:43 AM Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: > > * If CR4.PCIDE is changed 1 -> 0, the guest TLB must be flushed. > * If CR4.PCIDE is changed 0 -> 1, there is no need to flush the TLB > * according to the SDM; however, stale prev_roots could be reused > * reused incorrectly by MOV to CR3 with NOFLUSH=1, so we free them > * all. KVM_REQ_MMU_RELOAD is fit for the both cases; it > * is slow, but changing CR4.PCIDE is a rare case. > There is a double "reused" separated by "\". > > > Can you confirm the above comments are accurate? > Yes, they are better and consistent with what I meant, only one redundant "reused" in the comments. thanks Lai
