On Tue, Oct 19, 2021, David Matlack wrote: > slot_handle_leaf is a misnomer because it only operates on 4K SPTEs > whereas "leaf" is used to describe any valid terminal SPTE (4K or > large page). Rename slot_handle_leaf to slot_handle_level_4k to > avoid confusion. > > Making this change makes it more obvious there is a benign discrepency > between the legacy MMU and the TDP MMU when it comes to dirty logging. > The legacy MMU only iterates through 4K SPTEs when zapping for > collapsing and when clearing D-bits. The TDP MMU, on the other hand, > iterates through SPTEs on all levels. > > The TDP MMU behavior of zapping SPTEs at all levels is technically > overkill for its current dirty logging implementation, which always > demotes to 4k SPTES, but both the TDP MMU and legacy MMU zap if and only > if the SPTE can be replaced by a larger page, i.e. will not spuriously > zap 2m (or larger) SPTEs. Opportunistically add comments to explain this > discrepency in the code. > > Signed-off-by: David Matlack <dmatlack@xxxxxxxxxx> > --- Reviewed-by: Sean Christopherson <seanjc@xxxxxxxxxx>
