> +/* returns true if the get was obtained */ > +static bool vfio_group_try_get(struct vfio_group *group) > { > + return refcount_inc_not_zero(&group->users); > } Do we even need this helper? Just open coding the refcount_inc_not_zero would seem easier to read to me, and there is just a single caller anyway. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>