On 10/13/21 12:27 PM, Janosch Frank wrote: > The variable names for the snippet objects are of gigantic length so > let's define a few macros to make them easier to read. > > Also add a standard PSW which should be used to start the snippet. > > Signed-off-by: Janosch Frank <frankja@xxxxxxxxxxxxx> > --- > lib/s390x/snippet.h | 40 ++++++++++++++++++++++++++++++++++++++++ > s390x/mvpg-sie.c | 13 ++++++------- > 2 files changed, 46 insertions(+), 7 deletions(-) > create mode 100644 lib/s390x/snippet.h > > diff --git a/lib/s390x/snippet.h b/lib/s390x/snippet.h > new file mode 100644 > index 00000000..9ead4fe3 > --- /dev/null > +++ b/lib/s390x/snippet.h > @@ -0,0 +1,40 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Snippet definitions > + * > + * Copyright IBM, Corp. 2021 ^ That comma should not be there. > + * Author: Janosch Frank <frankja@xxxxxxxxxxxxx> > + */ > + [...]