Re: [PATCH v2 3/4] KVM: nVMX: Track whether changes in L0 require MSR bitmap for L2 to be rebuilt

Subject: Re: [PATCH v2 3/4] KVM: nVMX: Track whether changes in L0 require MSR bitmap for L2 to be rebuilt
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Mon, 11 Oct 2021 18:44:19 +0200
Cc: kvm@xxxxxxxxxxxxxxx, Wanpeng Li <wanpengli@xxxxxxxxxxx>, Jim Mattson <jmattson@xxxxxxxxxx>, Maxim Levitsky <mlevitsk@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <87zgrfzj9k.fsf@vitty.brq.redhat.com>
References: <20211004161029.641155-1-vkuznets@redhat.com> <20211004161029.641155-4-vkuznets@redhat.com> <YWDaOf/10znebx5S@google.com> <87zgrfzj9k.fsf@vitty.brq.redhat.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0

On 11/10/21 17:13, Vitaly Kuznetsov wrote:


The changelog kind of covers that, but those details will be completely lost to
readers of the code.

Would it help if we rename 'msr_bitmap_changed' to something?


Yeah, what about 'msr_bitmap_force_recalc'?

Paolo

References:
- [PATCH v2 0/4] KVM: nVMX: Enlightened MSR Bitmap feature for Hyper-V on KVM
  - From: Vitaly Kuznetsov
- [PATCH v2 3/4] KVM: nVMX: Track whether changes in L0 require MSR bitmap for L2 to be rebuilt
  - From: Vitaly Kuznetsov
- Re: [PATCH v2 3/4] KVM: nVMX: Track whether changes in L0 require MSR bitmap for L2 to be rebuilt
  - From: Sean Christopherson
- Re: [PATCH v2 3/4] KVM: nVMX: Track whether changes in L0 require MSR bitmap for L2 to be rebuilt
  - From: Vitaly Kuznetsov