Belated "code review" for Maxim's recent series to rework the AVIC inhibit code. Using the global APICv status in the page fault path is wrong as the correct status is always the vCPU's, since that status is accurate with respect to the time of the page fault. In a similar vein, the code to change the inhibit can be cleaned up since KVM can't rely on ordering between the update and the request for anything except consumers of the request. Sean Christopherson (2): KVM: x86/mmu: Use vCPU's APICv status when handling APIC_ACCESS memslot KVM: x86: Simplify APICv update request logic arch/x86/kvm/mmu/mmu.c | 2 +- arch/x86/kvm/x86.c | 16 +++++++--------- 2 files changed, 8 insertions(+), 10 deletions(-) -- 2.33.0.882.g93a45727a2-goog