Missing review: 0005-target-i386-sev-Prefix-QMP-errors-with-SEV.patch 0012-target-i386-sev-Use-g_autofree-in-sev_launch_get_mea.patch 0014-target-i386-sev-Rename-sev_i386.h-sev.h.patch 0016-target-i386-sev-Remove-stubs-by-using-code-elision.patch 0023-MAINTAINERS-Cover-SEV-related-files-with-X86-KVM-sec.patch Hi, While testing James & Dov patch: https://www.mail-archive.com/qemu-devel@xxxxxxxxxx/msg810571.html I wasted some time trying to figure out how OVMF was supposed to behave until realizing the binary I was using was built without SEV support... Then wrote this series to help other developers to not hit the same problem. Since v3: - Rebased ('Measured Linux SEV guest' from Dov [1] merged) - Addressed Paolo & David review comments Since v2: - Rebased on top of SGX - Addressed review comments from Markus / David - Included/rebased 'Measured Linux SEV guest' from Dov [1] - Added orphean MAINTAINERS section [1] https://lore.kernel.org/qemu-devel/20210825073538.959525-1-dovmurik@xxxxxxxxxxxxx/ Supersedes: <20210616204328.2611406-1-philmd@xxxxxxxxxx> Dr. David Alan Gilbert (1): target/i386/sev: sev_get_attestation_report use g_autofree Philippe Mathieu-Daudé (22): qapi/misc-target: Wrap long 'SEV Attestation Report' long lines qapi/misc-target: Group SEV QAPI definitions target/i386/kvm: Introduce i386_softmmu_kvm Meson source set target/i386/kvm: Restrict SEV stubs to x86 architecture target/i386/sev: Prefix QMP errors with 'SEV' target/i386/monitor: Return QMP error when SEV is not enabled for guest target/i386/cpu: Add missing 'qapi/error.h' header target/i386/sev_i386.h: Remove unused headers target/i386/sev: Remove sev_get_me_mask() target/i386/sev: Mark unreachable code with g_assert_not_reached() target/i386/sev: Use g_autofree in sev_launch_get_measure() target/i386/sev: Restrict SEV to system emulation target/i386/sev: Rename sev_i386.h -> sev.h target/i386/sev: Declare system-specific functions in 'sev.h' target/i386/sev: Remove stubs by using code elision target/i386/sev: Move qmp_query_sev_attestation_report() to sev.c target/i386/sev: Move qmp_sev_inject_launch_secret() to sev.c target/i386/sev: Move qmp_query_sev_capabilities() to sev.c target/i386/sev: Move qmp_query_sev_launch_measure() to sev.c target/i386/sev: Move qmp_query_sev() & hmp_info_sev() to sev.c monitor: Reduce hmp_info_sev() declaration MAINTAINERS: Cover SEV-related files with X86/KVM section qapi/misc-target.json | 77 ++++++------ include/monitor/hmp-target.h | 1 + include/monitor/hmp.h | 1 - include/sysemu/sev.h | 28 ----- target/i386/{sev_i386.h => sev.h} | 35 ++++-- hw/i386/pc_sysfw.c | 2 +- hw/i386/x86.c | 2 +- target/i386/cpu.c | 16 +-- target/i386/kvm/kvm.c | 3 +- {accel => target/i386}/kvm/sev-stub.c | 2 +- target/i386/monitor.c | 92 +-------------- target/i386/sev-stub.c | 88 -------------- target/i386/sev-sysemu-stub.c | 70 +++++++++++ target/i386/sev.c | 164 +++++++++++++++++++------- MAINTAINERS | 2 + accel/kvm/meson.build | 1 - target/i386/kvm/meson.build | 8 +- target/i386/meson.build | 4 +- 18 files changed, 279 insertions(+), 317 deletions(-) delete mode 100644 include/sysemu/sev.h rename target/i386/{sev_i386.h => sev.h} (62%) rename {accel => target/i386}/kvm/sev-stub.c (94%) delete mode 100644 target/i386/sev-stub.c create mode 100644 target/i386/sev-sysemu-stub.c -- 2.31.1
