On 10/4/21 11:57, Dr. David Alan Gilbert wrote:
> * Philippe Mathieu-Daudé (philmd@xxxxxxxxxx) wrote:
>> Move qmp_query_sev_attestation_report() from monitor.c to sev.c
>> and make sev_get_attestation_report() static. We don't need the
>> stub anymore, remove it.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
>> ---
>> target/i386/sev_i386.h | 2 --
>> target/i386/monitor.c | 6 ------
>> target/i386/sev-sysemu-stub.c | 7 ++++---
>> target/i386/sev.c | 12 ++++++++++--
>> 4 files changed, 14 insertions(+), 13 deletions(-)
>> -SevAttestationReport *sev_get_attestation_report(const char *mnonce,
>> - Error **errp)
>> +SevAttestationReport *qmp_query_sev_attestation_report(const char *mnonce,
>> + Error **errp)
>> {
>> - error_setg(errp, "SEV is not available in this QEMU");
>> + error_setg(errp, QERR_UNSUPPORTED);
>
> I did like that message making it clear the reason it was unsupported
> was this build, rather than lack of host support or not enabling it.
Yep, no reason to change it, besides, QERR_UNSUPPORTED is deprecated
since 2015! (commit 4629ed1e989):
/*
* These macros will go away, please don't use in new code, and do not
* add new ones!
*/
I suppose this is a rebase mistake, thanks for catching it!
Phil.
