Re: [kvm-unit-tests PATCH] s390x/mvpg-sie: Remove unused variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/7/21 09:21, Thomas Huth wrote:
The guest_instr variable is not used, which was likely a
copy-n-paste issue from the s390x/sie.c test.

Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx>

Reviewed-by: Janosch Fran <frankja@xxxxxxxxxxxxx>
Thanks, picked.

Weird that the compiler didn't complain with a set but not used message...

---
  s390x/mvpg-sie.c | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/s390x/mvpg-sie.c b/s390x/mvpg-sie.c
index ccc273b..5adcec1 100644
--- a/s390x/mvpg-sie.c
+++ b/s390x/mvpg-sie.c
@@ -21,7 +21,6 @@
  #include <sie.h>
static u8 *guest;
-static u8 *guest_instr;
  static struct vm vm;
static uint8_t *src;
@@ -94,8 +93,6 @@ static void setup_guest(void)
/* Allocate 1MB as guest memory */
  	guest = alloc_pages(8);
-	/* The first two pages are the lowcore */
-	guest_instr = guest + PAGE_SIZE * 2;
sie_guest_create(&vm, (uint64_t)guest, HPAGE_SIZE);




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux