On 10/4/21 10:23, Paolo Bonzini wrote: > On 02/10/21 14:53, Philippe Mathieu-Daudé wrote: >> Move qmp_query_sev_attestation_report() from monitor.c to sev.c >> and make sev_get_attestation_report() static. We don't need the >> stub anymore, remove it. >> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> > > This was done on purpose, but I have no objection to changing it this > way. We might in fact remove the indirection for SGX as well, and/or > even move the implementation of the monitor commands from target/i386 to > hw/i386 (the monitor is sysemu-specific). OK about SGX, but in another series, this one is already painful enough. Not sure about moving monitor to hw/, some commands expose hw info (like info pic) but some others expose architectural features (like info sev). > > Reviewed-by: Paolo Bonzini <pbonzini@xxxxxxxxxx> > > Thanks, > > Paolo
