On 02/10/21 14:53, Philippe Mathieu-Daudé wrote:
The unique sev_encrypt_flash() invocation (in pc_system_flash_map)
is protected by the "if (sev_enabled())" check, so is not
reacheable.
Replace the abort() call in sev_es_save_reset_vector() by
g_assert_not_reached() which meaning is clearer.
Reviewed-by: Connor Kuehl <ckuehl@xxxxxxxxxx>
Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
---
target/i386/sev-stub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/i386/sev-stub.c b/target/i386/sev-stub.c
index eb0c89bf2be..4668365fd3e 100644
--- a/target/i386/sev-stub.c
+++ b/target/i386/sev-stub.c
@@ -54,7 +54,7 @@ int sev_inject_launch_secret(const char *hdr, const char *secret,
int sev_encrypt_flash(uint8_t *ptr, uint64_t len, Error **errp)
{
- return 0;
+ g_assert_not_reached();
}
bool sev_es_enabled(void)
@@ -68,7 +68,7 @@ void sev_es_set_reset_vector(CPUState *cpu)
int sev_es_save_reset_vector(void *flash_ptr, uint64_t flash_size)
{
- abort();
+ g_assert_not_reached();
}
SevAttestationReport *
Reviewed-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
