On 30/09/21 00:24, Sean Christopherson wrote:
* RESET since KVM emulates RESET before exposing the vCPU to userspace, * i.e. it'simpossible for kvm_cpuid() to find a valid entry on RESET. + * But, go through the motions in case that's ever remedied. Note, the + * index for CPUID.0x1 is not significant, arbitrarily specify '0'.
Just one nit, this comment change is not really needed because almost all callers are using '0' for the same reason.
But, perhaps adding kvm_find_cpuid_entry_index and removing the last parameter from kvm_find_cpuid_entry would be a good idea.
Also, the kvm_cpuid() reference needs to be changed, which I did upon commit.
Paolo
*/ - eax = 1; - if (!kvm_cpuid(vcpu, &eax, &dummy, &dummy, &dummy, true)) - eax = 0x600; - kvm_rdx_write(vcpu, eax); + cpuid_0x1 = kvm_find_cpuid_entry(vcpu, 1, 0); + kvm_rdx_write(vcpu, cpuid_0x1 ? cpuid_0x1->eax : 0x600);
