On 9/27/21 19:41, Thomas Huth wrote:
On 22/09/2021 09.18, Janosch Frank wrote:
Every time something goes wrong in a way we don't expect, we need to
add debug prints to some UVC to get the unexpected return code.
Let's just put the printing behind a macro so we can enable it if
needed via a simple switch.
Signed-off-by: Janosch Frank <frankja@xxxxxxxxxxxxx>
---
lib/s390x/asm/uv.h | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/lib/s390x/asm/uv.h b/lib/s390x/asm/uv.h
index 2f099553..0e958ad7 100644
--- a/lib/s390x/asm/uv.h
+++ b/lib/s390x/asm/uv.h
@@ -12,6 +12,9 @@
#ifndef _ASMS390X_UV_H_
#define _ASMS390X_UV_H_
+/* Enables printing of command code and return codes for failed UVCs */
+#define UVC_ERR_DEBUG 0
Do we maybe want a "#ifndef UVC_ERR_DEBUG" in front of this, so that we
could also set the macro to 1 from individual *.c files (or from the Makefile)?
Thomas
When testing it's the least amount of work to set this to 1 so I
implemented it this way. If you think it's useful then I'll add the ifndef.